Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-96706: [doc] Don't recommend deprecated use of get_event_loop() in examples (GH-96707) #96757

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 11, 2022

…p() in examples (pythonGH-96707)

(cherry picked from commit 53a54b7)

Co-authored-by: zhanpon <pon.zhan@gmail.com>
@gvanrossum
Copy link
Member

This will have to wait until 3.11.1.

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅.

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@chalggg
Copy link

chalggg commented Sep 13, 2022

There is a typo in commit description. Should be recommend (with 'd' as last letter).

@gvanrossum gvanrossum changed the title [3.11] gh-96706: [doc] Don't recomment deprecated use of get_event_loop() in examples (GH-96707) [3.11] gh-96706: [doc] Don't recommend deprecated use of get_event_loop() in examples (GH-96707) Sep 13, 2022
@miss-islington miss-islington merged commit 6726405 into python:3.11 Sep 13, 2022
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington deleted the backport-53a54b7-3.11 branch September 13, 2022 15:57
@gvanrossum
Copy link
Member

There is a typo in commit description. Should be recommend (with 'd' as last letter).

Too bad, it's already been merged, there is no way to edit commit titles once merged. I've updated the PR subject, at least.

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants