Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-96754: Check whether the interpreter frame is complete before creating frame object. #96776

Merged
merged 2 commits into from
Sep 13, 2022
Merged

GH-96754: Check whether the interpreter frame is complete before creating frame object. #96776

merged 2 commits into from
Sep 13, 2022

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Sep 12, 2022 •
edited by bedevere-bot
Loading

Fixes three possible cases of frame objects being created from incomplete frames.

@kumaraditya303 kumaraditya303 added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes labels Sep 12, 2022
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 12, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 175b135 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 12, 2022
@markshannon markshannon merged commit 12c5f32 into python:main Sep 13, 2022
@miss-islington
Copy link
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2022
@markshannon @miss-islington
pythonGH-96754: Check whether the interpreter frame is complete befor…
e28cce6 
…e creating frame object. (pythonGH-96776)

(cherry picked from commit 12c5f32)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 13, 2022
@bedevere-bot
Copy link

GH-96787 is a backport of this pull request to the 3.11 branch.

pablogsal pushed a commit that referenced this pull request Sep 13, 2022
@miss-islington @markshannon
GH-96754: Check whether the interpreter frame is complete before crea…
c4cf745 
…ting frame object. (GH-96776) (#96787)

(cherry picked from commit 12c5f32)

Co-authored-by: Mark Shannon <mark@hotpy.org>

Co-authored-by: Mark Shannon <mark@hotpy.org>
@ericsnowcurrently ericsnowcurrently mentioned this pull request Sep 21, 2022
Closed
@markshannon markshannon deleted the guard-incomplete-frame-in-signal-handler branch September 26, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markshannon @bedevere-bot @miss-islington @kumaraditya303