Add dataclass field default change to 3.11 what's new #96790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include dataclass field default mutability check change introduced in python#29867. See [discourse discussion](https://discuss.python.org/t/better-communicate-dataclass-mutable-default-check-change-in-python-3-11)
EpicWink
changed the title
hugovk
reviewed
Sep 13, 2022
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
@ericsnowcurrently How does this look as a What's New for #29867? |
I think you got the wrong Eric — you want @ericvsmith! |
gvanrossum
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
@pablogsal What is your position on doc changes post rc2? Especially the what's new would be nice to be up to date.
|
Thanks @EpicWink for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-96802 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2022
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> (cherry picked from commit 4995f5f) Co-authored-by: Laurie O <laurie_opperman@hotmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 13, 2022
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> (cherry picked from commit 4995f5f) Co-authored-by: Laurie O <laurie_opperman@hotmail.com>
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2022
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> (cherry picked from commit 4995f5f) Co-authored-by: Laurie O <laurie_opperman@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include dataclass field default mutability check change introduced in #29867. See discourse discussion