Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-95921: Fix positions for some chained comparisons #96968

Merged
merged 3 commits into from
Sep 20, 2022
Merged

GH-95921: Fix positions for some chained comparisons #96968

merged 3 commits into from
Sep 20, 2022

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Sep 20, 2022 •
edited by bedevere-bot
Loading

@brandtbucher brandtbucher self-assigned this Sep 20, 2022
@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes type-bug An unexpected behavior, bug, or error labels Sep 20, 2022
iritkatriel
iritkatriel approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@brandtbucher brandtbucher merged commit dfc73b5 into python:main Sep 20, 2022
@miss-islington
Copy link
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @brandtbucher, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dfc73b57247aac575c83055d960c03bdc28b51fd 3.11

@miss-islington
Copy link
Contributor

Sorry @brandtbucher, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker dfc73b57247aac575c83055d960c03bdc28b51fd 3.10

brandtbucher added a commit to brandtbucher/cpython that referenced this pull request Sep 20, 2022
@brandtbucher
pythonGH-95921: Fix positions for some chained comparisons (pythonGH-…
da93813 
…96968)

(cherry picked from commit dfc73b5)
brandtbucher added a commit to brandtbucher/cpython that referenced this pull request Sep 20, 2022
@brandtbucher
[3.11] pythonGH-95921: Fix positions for some chained comparisons (py…
51ea608 
…thonGH-96968).

(cherry picked from commit dfc73b5)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
brandtbucher added a commit to brandtbucher/cpython that referenced this pull request Sep 20, 2022
@brandtbucher
[3.11] pythonGH-95921: Fix positions for some chained comparisons (py…
733ccf4 
…thonGH-96968).

(cherry picked from commit dfc73b5)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
@bedevere-bot
Copy link

GH-96973 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 20, 2022
brandtbucher added a commit to brandtbucher/cpython that referenced this pull request Sep 20, 2022
@brandtbucher
[3.10] pythonGH-95921: Fix positions for some chained comparisons (py…
292910f 
…thonGH-96968).

(cherry picked from commit dfc73b5)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 20, 2022
@bedevere-bot
Copy link

GH-96974 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit that referenced this pull request Sep 20, 2022
@brandtbucher
[3.11] GH-95921: Fix positions for some chained comparisons (GH-96968) (
0e61d2b 
GH-96973)

(cherry picked from commit dfc73b5)

Automerge-Triggered-By: GH:brandtbucher
miss-islington pushed a commit that referenced this pull request Sep 20, 2022
@brandtbucher
[3.10] GH-95921: Fix positions for some chained comparisons (GH-96968) (
aced809 
GH-96974)

(cherry picked from commit dfc73b5)

Automerge-Triggered-By: GH:brandtbucher
@iritkatriel iritkatriel mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandtbucher @miss-islington @bedevere-bot @iritkatriel