Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-91051: allow setting a callback hook on PyType_Modified #97875

Merged
merged 21 commits into from
Oct 21, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Short circuit watched bits check if no more bits are set
carljm committed Oct 20, 2022

Verified

This commit was signed with the committer’s verified signature.
carljm Carl Meyer
commit 22d190b0adced2a90130624e6e172224eb1a7741
6 changes: 4 additions & 2 deletions Objects/typeobject.c
Original file line number Diff line number Diff line change
@@ -488,14 +488,16 @@ PyType_Modified(PyTypeObject *type)

if (type->tp_watched) {
PyInterpreterState *interp = _PyInterpreterState_GET();
char bits = type->tp_watched;
for (int i = 0; i < TYPE_MAX_WATCHERS; i++) {
int bits = type->tp_watched;
int i = 0;
while(bits && i < TYPE_MAX_WATCHERS) {
if (bits & 1) {
PyType_WatchCallback cb = interp->type_watchers[i];
if (cb && (cb(type) < 0)) {
PyErr_WriteUnraisable((PyObject *)type);
}
}
i += 1;
bits >>= 1;
}
}