Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-97956: Mention generate_global_objects.py in AC How-To #97957

Merged
merged 4 commits into from
Oct 7, 2022
Merged

gh-97956: Mention generate_global_objects.py in AC How-To #97957

merged 4 commits into from
Oct 7, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 6, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 6, 2022
@sobolevn
Copy link
Member Author

sobolevn commented Oct 6, 2022

Looks like GitHub Actions are broken right now. I will re-run the CI a bit later.

@sobolevn
Copy link
Member Author

sobolevn commented Oct 6, 2022

Re-triggering

@sobolevn sobolevn closed this Oct 6, 2022
@sobolevn sobolevn reopened this Oct 6, 2022
larryhastings
larryhastings reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@larryhastings larryhastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea to add this step to the documentation. But I have some suggestions on how to rewrite the text to make it a little clearer. Please take a look!

Doc/howto/clinic.rst Outdated
@@ -539,7 +539,17 @@ Let's dive in!
};


16. Compile, then run the relevant portions of the regression-test suite.
16. Code generated by Argument Clinic might use ``_Py_ID`` macro inside.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Argument Clinic may generate new instances of _Py_ID. For example::

Doc/howto/clinic.rst Outdated

&_Py_ID(new_unique_py_id)

It means that you would need to run ``Tools/scripts/generate_global_objects.py``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it does, you'll have to run Tools/scripts/generate_global_objects.py to regenerate the list of precompiled identifiers at this point.

Copy link
Member Author

@sobolevn sobolevn Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done!

It is always great to have native-speakers to double check things like this. I think in another language and it does not translate that well into English in some cases :)

@sobolevn
Copy link
Member Author

sobolevn commented Oct 6, 2022

Looks like the CI failure is somehow related to f612565

@JulienPalard
Copy link
Member

@sobolevn I think that the CI issues has been fixed (sphinx-lint side for some false postives, and cpython side for the few true positives), can you please rebase your branch on top of main?

@sobolevn sobolevn closed this Oct 7, 2022
@sobolevn sobolevn reopened this Oct 7, 2022
@sobolevn
Copy link
Member Author

sobolevn commented Oct 7, 2022

It works now 🎉

@JulienPalard
Copy link
Member

It works now tada

Yeah! It's better like that :)

Sorry for the inconvenience :(

@ambv ambv merged commit 586cfb0 into python:main Oct 7, 2022
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
27a4980 
* main: (38 commits)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  pythonGH-83901: Improve Signature.bind error message for missing keyword-only params (python#95347)
  pythongh-61105: Add default param, note on using cookiejar subclass (python#95427)
  pythongh-96288: Add a sentence to `os.mkdir`'s docstring. (python#96271)
  pythongh-96073: fix backticks in NEWS entry (pythonGH-98056)
  pythongh-92886: [clinic.py] raise exception on invalid input instead of assertion (pythonGH-98051)
  pythongh-97997: Add col_offset field to tokenizer and use that for AST nodes (python#98000)
  pythonGH-88968: Reject socket that is already used as a transport (python#98010)
  pythongh-96346: Use double caching for re._compile() (python#96347)
  pythongh-91708: Revert params note in urllib.parse.urlparse table (python#96699)
  pythongh-96265: Fix some formatting in faq/design.rst (python#96924)
  pythongh-73196: Add namespace/scope clarification for inheritance section (python#92840)
  pythongh-97646: Change `.js` and `.mjs` files mimetype to conform to RFC 9239 (python#97934)
  pythongh-97923: Always run Ubuntu SSL tests with others in CI (python#97940)
  pythongh-97956: Mention `generate_global_objects.py` in `AC How-To` (python#97957)
  pythongh-96959: Update HTTP links which are redirected to HTTPS (python#98039)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@sobolevn @mpage
pythongh-97956: Mention generate_global_objects.py in AC How-To (p…
8bc17aa 
…ython#97957)
erlend-aasland pushed a commit to erlend-aasland/devguide that referenced this pull request Sep 8, 2023
@sobolevn @erlend-aasland
python/cpython#97956: Mention generate_global_objects.py in `AC How…
5e68687 
…-To` (python/cpython#97957)
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Sep 13, 2023
@sobolevn
python/cpython#97956: Mention generate_global_objects.py in `AC How…
5f6ac54 
…-To` (python/cpython#97957)
erlend-aasland pushed a commit to python/devguide that referenced this pull request Sep 26, 2023
@sobolevn @erlend-aasland
python/cpython#97956: Mention generate_global_objects.py in `AC How…
e630cce 
…-To` (python/cpython#97957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryhastings larryhastings larryhastings left review comments

@blockchainGuru1018 blockchainGuru1018 blockchainGuru1018 approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sobolevn @JulienPalard @larryhastings @blockchainGuru1018 @ambv @bedevere-bot