Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-94808: Cover PyFunction_GetCode, PyFunction_GetGlobals,… #98317

Merged
merged 1 commit into from
Oct 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions Lib/test/test_capi.py
Original file line number Diff line number Diff line change
Expand Up @@ -739,6 +739,41 @@ def method_example(self): ...
self.assertEqual(_testcapi.eval_get_func_name(sum), "sum") # c function
self.assertEqual(_testcapi.eval_get_func_name(A), "type")

def test_function_get_code(self):
import types

def some():
pass

code = _testcapi.function_get_code(some)
self.assertIsInstance(code, types.CodeType)
self.assertEqual(code, some.__code__)

with self.assertRaises(SystemError):
_testcapi.function_get_code(None) # not a function

def test_function_get_globals(self):
def some():
pass

globals_ = _testcapi.function_get_globals(some)
self.assertIsInstance(globals_, dict)
self.assertEqual(globals_, some.__globals__)

with self.assertRaises(SystemError):
_testcapi.function_get_globals(None) # not a function

def test_function_get_module(self):
def some():
pass

module = _testcapi.function_get_module(some)
self.assertIsInstance(module, str)
self.assertEqual(module, some.__module__)

with self.assertRaises(SystemError):
_testcapi.function_get_module(None) # not a function


class TestPendingCalls(unittest.TestCase):

Expand Down
40 changes: 40 additions & 0 deletions Modules/_testcapimodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -6081,6 +6081,43 @@ settrace_to_record(PyObject *self, PyObject *list)
}

static PyObject *negative_dictoffset(PyObject *, PyObject *);

static PyObject *
function_get_code(PyObject *self, PyObject *func)
{
PyObject *code = PyFunction_GetCode(func);
if (code != NULL) {
Py_INCREF(code);
return code;
} else {
return NULL;
}
}

static PyObject *
function_get_globals(PyObject *self, PyObject *func)
{
PyObject *globals = PyFunction_GetGlobals(func);
if (globals != NULL) {
Py_INCREF(globals);
return globals;
} else {
return NULL;
}
}

static PyObject *
function_get_module(PyObject *self, PyObject *func)
{
PyObject *module = PyFunction_GetModule(func);
if (module != NULL) {
Py_INCREF(module);
return module;
} else {
return NULL;
}
}

static PyObject *test_buildvalue_issue38913(PyObject *, PyObject *);
static PyObject *getargs_s_hash_int(PyObject *, PyObject *, PyObject*);
static PyObject *getargs_s_hash_int2(PyObject *, PyObject *, PyObject*);
Expand Down Expand Up @@ -6382,6 +6419,9 @@ static PyMethodDef TestMethods[] = {
{"get_feature_macros", get_feature_macros, METH_NOARGS, NULL},
{"test_code_api", test_code_api, METH_NOARGS, NULL},
{"settrace_to_record", settrace_to_record, METH_O, NULL},
{"function_get_code", function_get_code, METH_O, NULL},
{"function_get_globals", function_get_globals, METH_O, NULL},
{"function_get_module", function_get_module, METH_O, NULL},
{NULL, NULL} /* sentinel */
};

Expand Down