Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] gh-97909 : PyMemberDef members are not marked up #98425

Closed
wants to merge 2 commits into from

Conversation

Johnny11502
Copy link
Contributor

@Johnny11502 Johnny11502 commented Oct 19, 2022

Contents of PyMemberDef were not marked as members.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Oct 19, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 19, 2022
@JelleZijlstra
Copy link
Member

Any reason this is against the 3.10 branch? Normally we make changes on the main branch first, then backport them to the bugfix branches (currently 3.10 and 3.11).

@Johnny11502
Copy link
Contributor Author

@JelleZijlstra This is my first PR for this repo and GitHub in general. I just made the changes to the 3.10 branch which was linked in in the issue above. Would you like me to create a new PR or is there a way to correct it without doing so?

@JelleZijlstra
Copy link
Member

Welcome to CPython! It's going to be easiest to make a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants