gh-77753: Add example for values that compare equal in stdtypes #98497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slateny
commented
Oct 20, 2022
slateny
commented
Oct 20, 2022
| @@ -4370,8 +4370,8 @@ type, the :dfn:`dictionary`. (For other containers see the built-in | |||
| A dictionary's keys are *almost* arbitrary values. Values that are not | |||
There was a problem hiding this comment.
I don't like this "almost arbitrary values" wording, since several very common types (lists, dicts, sets) can't be used as dict keys. No need to change that in this PR though.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
slateny
commented
Oct 21, 2022
JelleZijlstra
approved these changes
Oct 26, 2022
JelleZijlstra
added
needs backport to 3.10
|
Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-98693 is a backport of this pull request to the 3.11 branch. |
|
GH-98694 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 26, 2022
…pythonGH-98497) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit 0ca6a4d) Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 26, 2022
…pythonGH-98497) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit 0ca6a4d) Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Oct 26, 2022
miss-islington
added a commit
that referenced
this pull request
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/dev/library/stdtypes.html#mapping-types-dict