gh-95913: Fix, sort & expand pending removal sect in 3.11 WhatsNew #98583
Conversation
CAM-Gerlach
added
3.11
CAM-Gerlach
force-pushed
the
whatsnew-edit-pending-removal
branch
from
974596e to
3f17a8e
Compare
pablogsal
changed the title
|
The docs are failing due to: WARNING: undefined label: deprecated-aliases |
Doc/whatsnew/3.11.rst
Outdated
|
|
||
| * :func:`!sqlite3.enable_shared_cache` | ||
| * :func:`!sqlite3.OptimizedUnicode` | ||
| * :mod:`unittest` ``fail*`` and ``assert*`` :ref:`deprecated-aliases` |
There was a problem hiding this comment.
| * :mod:`unittest` ``fail*`` and ``assert*`` :ref:`deprecated-aliases` | |
| * :mod:`unittest` ``fail*`` and ``assert*`` deprecated-aliases |
The section was removed in GH-92556.
There was a problem hiding this comment.
That's unfortunate because the line is hard to understand without links. As I understand it doesn't refer to all assert* method, just old aliases like assertEquals. Maybe we'll have to list the methods explicitly here?
There was a problem hiding this comment.
Yes. IMO the removed table should have been moved here. I'll make a commit.
There was a problem hiding this comment.
Pushed directly to CAM's branch, as it would have been awkward as a suggestion or PR-for-a-PR
There was a problem hiding this comment.
Thanks for the help and sorry for not being around; I was getting a few hours of sleep after staying at the office way too late past 4 am working on these.
Yeah, the table was removed but in 3.12 and still present in 3.11 where it mattered; my plan was to write the What's New against what would work in 3.11, and then go back later and fix the missing stuff for 3.12+, but I mistakenly thought the undefined label warning was due to -n rather than on by default (and an error with -W). In that case, just adding the full table was the best thing to do given the circumstances.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
Thanks @CAM-Gerlach for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
…New (pythonGH-98583) * Fix names/references of pending removal APIs * Sort list of APIs pending removal alphabetically * Add missing modules/submodules pending removal in 3.12 * Add table of unittest deprecated aliases to 3.11 What's New Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> (cherry picked from commit e19c2b9) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
|
GH-98600 is a backport of this pull request to the 3.11 branch. |
…H-98583) * Fix names/references of pending removal APIs * Sort list of APIs pending removal alphabetically * Add missing modules/submodules pending removal in 3.12 * Add table of unittest deprecated aliases to 3.11 What's New Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> (cherry picked from commit e19c2b9) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Part of #95913
This PR copyedits, sorts and fixes the syntax of the Pending Removal section of the What's New in Python 3.11 document. In particular, it:
It also adds several missing modules pending removal in 3.12 but not previously listed, specifically:
asynchatasyncoreimptyping.ionamespacetyping.renamespaceassert*andfail*) in theunittestmodule that were bumped from 3.11 to 3.12 in beta 1, but not listed anywhere in the document