-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-90699: fix refleak in _testcapimodule.c
#99236
Conversation
kumaraditya303
commented
Nov 8, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Replace _Py_IDENTIFIER() with statically initialized objects. #90699
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 5435423 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I check the leak and solution through
./python.exe -m test test_finalization -R 3:3
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 3.73 Run tests sequentially
0:00:00 load avg: 3.73 [1/1] test_finalization
beginning 6 repetitions
123456
......
== Tests result: SUCCESS ==
1 test OK.
Total duration: 1.0 sec
Tests result: SUCCESS
But please take a look at #99236 (comment) nit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!