Skip to content

GH-91095: Specialize calls to normal Python classes. #99331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 22, 2023
Merged

GH-91095: Specialize calls to normal Python classes. #99331

merged 13 commits into from
Jun 22, 2023

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Nov 10, 2022 •
edited by bedevere-bot
Loading

This is a manual rebase of #93221.

@markshannon markshannon mentioned this pull request Nov 10, 2022
Closed
@markshannon markshannon reopened this Nov 10, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 10, 2022
Closed
@brandtbucher brandtbucher self-requested a review November 18, 2022 21:02
This was referenced Nov 18, 2022
Closed
Closed
@python python deleted a comment from netlify bot Mar 10, 2023
brandtbucher
brandtbucher reviewed May 10, 2023
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still being considered for 3.13? I think it's one of the last big "important" cases to cover, but if it's too complex right now we can always kick the can down the road a little further...

carljm
carljm reviewed Jun 20, 2023
View reviewed changes
@markshannon
Copy link
Member Author

Is this still being considered for 3.13?

Yes, should be ready to go now

carljm
carljm approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@markshannon markshannon merged commit 04492cb into python:main Jun 22, 2023
bentasker pushed a commit to bentasker/cpython that referenced this pull request Jun 23, 2023
@markshannon @bentasker
pythonGH-91095: Specialize calls to normal Python classes. (pythonGH-…
b12f4ab 
…99331)
@markshannon markshannon deleted the specialize-calls-to-python-classes branch September 26, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher left review comments

@carljm carljm carljm approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@methane methane Awaiting requested review from methane methane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markshannon @carljm @brandtbucher @bedevere-bot