Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99300: Replace Py_INCREF() with Py_NewRef() #99513

Merged
merged 1 commit into from
Nov 16, 2022
Merged

gh-99300: Replace Py_INCREF() with Py_NewRef() #99513

merged 1 commit into from
Nov 16, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 15, 2022

Replace Py_INCREF() and Py_XINCREF() using a cast with Py_NewRef() and Py_XNewRef().

Replace Py_INCREF() and Py_XINCREF() using a cast with Py_NewRef()
and Py_XNewRef().
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for _asyncio and select. The others aren't my area of expertise.

@vstinner vstinner merged commit 3ed8803 into python:main Nov 16, 2022
@vstinner vstinner deleted the newref branch November 16, 2022 09:39
@vstinner
Copy link
Member Author

@gvanrossum: Thanks for your review.

It seems like GitHub automatically asked you to review your PR. I don't know how this work. Maybe it's based on .github/CODEOWNERS. I didn't want to spam all maintainers with my current refactoring work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants