gh-99708: fix bug where compiler crashes on if expression with an empty body block #99732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an empty body block
iritkatriel
added
interpreter-core
corona10
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99708.
The crash comes from a cleanup sequence where we call
eliminate_empty_basic_blocks()followed byremove_redundant_nops(). Later we assert that there are no empty blocks, but removing a redundant NOP can create an empty basic block.I don't think that removing empty blocks can create new redundant NOPs. So this PR reverses the order, and add a debug assertion afterwards that there are no redundant NOPs.