Skip to content

Document when it's okay to dismiss another core dev's review #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brettcannon opened this issue Apr 10, 2017 · 0 comments
Closed

Document when it's okay to dismiss another core dev's review #161

brettcannon opened this issue Apr 10, 2017 · 0 comments

Comments

@brettcannon
Copy link
Member

If a core dev requests changes, when it is okay to dismiss that request? Discussion in python/core-workflow#36 and the reached conclusion that we should probably document.
@brettcannon brettcannon mentioned this issue Apr 10, 2017
Closed
Mariatta added a commit to Mariatta/devguide that referenced this issue Apr 24, 2017
@Mariatta
Document when a review can be dismissed.
7ca2308 
Closes python#161
@Mariatta Mariatta mentioned this issue Apr 24, 2017
Merged
willingc pushed a commit that referenced this issue Apr 24, 2017
@Mariatta @willingc
Document when a review can be dismissed. (#176)
408de29 
Closes #161
AA-Turner pushed a commit to AA-Turner/devguide that referenced this issue Jun 17, 2022
@Mariatta @willingc
Document when a review can be dismissed. (python#176)
742e9e7 
Closes python#161
kitarefake added a commit to kitarefake/devguide that referenced this issue Jul 15, 2024
@kitarefake @willingc
Document when a review can be dismissed. (#176)
5432c7d 
Closes python/devguide#161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brettcannon