Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update patchcheck description #1031

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Update patchcheck description #1031

merged 3 commits into from
Jan 16, 2023

Conversation

EvanLai88
Copy link
Contributor

patchcheck.py, reindent.py are moved from Tools\scripts\ to Tools\patchcheck\
Ref: python/cpython#98186

reindent-rst.py are deleted.
whitespaces in docs are handled by patchcheck.py itself
Ref: python/cpython#97675

CAM-Gerlach
CAM-Gerlach reviewed Jan 15, 2023
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth updating the CPython source file paths in this section to use :cpy-file:, so that the actual files are linked directly, and in the future linkcheck will report a warning if they are ever moved or deleted again?

getting-started/pull-request-lifecycle.rst Outdated Show resolved Hide resolved
@EvanLai88 @CAM-Gerlach
Link with :cpy-file: directly
7c801b9 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach
CAM-Gerlach approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, FWIW

@ezio-melotti ezio-melotti merged commit 55b0c14 into python:main Jan 16, 2023
@EvanLai88 EvanLai88 deleted the patchcheck-py branch February 3, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EvanLai88 @CAM-Gerlach @ezio-melotti