Maintain support for pre-Python 3.11 #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
approved these changes
Jun 4, 2023
There was a problem hiding this comment.
LGTM, except for some related fixes to the readme phrasing. Thanks @hugovk !
ezio-melotti
approved these changes
Jun 4, 2023
CAM-Gerlach
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #1097 (comment)
Let's maintain support for Python versions earlier than 3.11.
Done as an
if/elserather than a long ternary, as tools like pyupgrade can automatically remove the old code when the time comes.📚 Documentation preview 📚: https://cpython-devguide--1107.org.readthedocs.build/