Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -j auto to the Makefile. #1220

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Nov 15, 2023

This PR adds -j auto to the Makefile.

I found out that it was missing while working on sphinx-doc/sphinx#10779, and after adding it the time required to build the devguide went down from 2.9s to 1.4s, so about twice as fast (this is on a 16-cores CPU).


📚 Documentation preview 📚: https://cpython-devguide--1220.org.readthedocs.build/

BUILDER = html
SPHINXLINT = $(VENVDIR)/bin/sphinx-lint
JOBS = auto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JOBS = auto and the -j $(JOBS) below are the only actual additions. While I was at it I tried to reorganize the vars a bit to make them closer to cpython's Doc/Makefile, including the order of the vars below.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little speedup!

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Hugo's suggestion, LGTM

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@ezio-melotti ezio-melotti merged commit 7e9a415 into python:main Nov 29, 2023
2 checks passed
@ezio-melotti ezio-melotti deleted the makefile-jauto branch November 29, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants