Add "how to" for the getter Argument Clinic directive. #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
force-pushed
the
gh-112205-getter
branch
from
dc17090 to
e9d9ed2
Compare
|
@AlexWaygood GitHub UI fail on my part! I've fixed it locally and force pushed! Sorry about that! |
No worries -- I was briefly worried your account had been hacked! 😅 |
|
OK, so I meant to delete a pending review comment:
But picked the wrong "..." and chose "Discard changes" here:
Lesson learned. Sorry again @corona10! |
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
AlexWaygood
reviewed
Nov 29, 2023
AlexWaygood
reviewed
Nov 30, 2023
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
Nov 30, 2023
|
LGTM, given Alex's final remarks are addressed :) Thank you so much, Donghee! |
erlend-aasland
approved these changes
Nov 30, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
Thank you @AlexWaygood, @erlend-aasland, @hugovk and @ezio-melotti :) |
|
Thanks so much @corona10, this is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-devguide--1232.org.readthedocs.build/