Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add procedure for adding people to the Python Triage team #521

Merged
merged 5 commits into from
Aug 17, 2019

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Aug 9, 2019

@nanjekyejoannah
Copy link
Contributor

A suggestion from what I posted on discuss. To reduce traffic to the core team, is there a problem or risk with current bpo triagers publicly opening an issue in core-workflow with details confirming they have triage rights on bpo already and requesting to be added to the Python Triage Team?

Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Mariatta. I think this extensively covers the consensus reached in the Discuss topic. I had a few minor suggestions, but I would approve of this section either way.

triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated
has access to more repositories than just CPython. Triages will be responsible
to handle not just issues, but also pull requests, and even commanding backports.

Any existing triagers in b.p.o can transition to the Python Triage role.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even simpler:

Suggested change
Any existing triagers in b.p.o can transition to the Python Triage role.
Any existing triager in b.p.o can become a Python triager.

Copy link
Contributor

@aeros aeros Aug 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think that we should refer a member of the role on on bpo as a "developer". That is the official name of the role on there, and it also helps to avoid confusing it with the new Python triagers on GitHub.

triaging.rst Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
triaging.rst Outdated Show resolved Hide resolved
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
@Mariatta
Copy link
Member Author

To reduce traffic to the core team,

Promoting and recognizing contributors and triagers are responsibilities of core developers.

If for some reason core devs find this too noisy, can they can filter out Github email notification containing "Request for Python Triage membership". But that should be personal choice.

@Mariatta
Copy link
Member Author

Additionally, there is potential for automating the process (described in python/core-workflow#350)
Once we have that in place, the only thing a core dev needs to do is "approving" the request by applying a label.

@aeros
Copy link
Contributor

aeros commented Aug 12, 2019

Once we have that in place, the only thing a core dev needs to do is "approving" the request by applying a label.

Awesome! This would definitely be far more time effective than requiring a core dev to contact an org admin, and requiring them to manually invite the person as a triager.

If the steering council decided to block the promotion, the persons permissions could simply be removed. But perhaps a better way to do this would require a set amount from when the PR is approved to when they're sent the invite.

also change from privately -> confidentially
@eamanu
Copy link
Contributor

eamanu commented Aug 15, 2019

Good! maybe will be great mention if anybody apply (or self apply) to be a member of the team,
and is denied, we can mention that they can apply again later ( or wait X time).

What do you think?

@Mariatta Mariatta merged commit 38880a2 into master Aug 17, 2019
@Mariatta Mariatta deleted the Mariatta-patch-2 branch August 17, 2019 14:58
@Mariatta
Copy link
Member Author

Thanks all for the reviews.

maybe will be great mention if anybody apply (or self apply) to be a member of the team,
and is denied, we can mention that they can apply again later ( or wait X time).

Sounds great. Feel free to propose a PR for this.

AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the devguide with the discussion on bug triage
6 participants