Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete packages_distributions #428

Closed
FFY00 opened this issue Jan 23, 2023 · 1 comment · Fixed by #432
Closed

Incomplete packages_distributions #428

FFY00 opened this issue Jan 23, 2023 · 1 comment · Fixed by #432

Comments

@FFY00
Copy link
Member

FFY00 commented Jan 23, 2023

The search logic is very limited. I understand that we probably just wanted to keep things simple when it was added, but I want to understand if there's any plan to improve it?

def _top_level_inferred(dist):
return {
f.parts[0] if len(f.parts) > 1 else f.with_suffix('').name
for f in always_iterable(dist.files)
if f.suffix == ".py"
}

In meson-python, I had to implement a more complete version of this logic. Would it make sense to port it here?

https://github.com/mesonbuild/meson-python/blob/61bb2b3315f4e312558778022ca6e87ffaed2700/mesonpy/__init__.py#L336-L359

@FFY00 FFY00 changed the title packages_distributions is limited to pure-Python non-package modules Incomplete packages_distributions Mar 10, 2023
@FFY00
Copy link
Member Author

FFY00 commented Mar 10, 2023

The current logic only returns pure Python top-level modules or package modules with at least one .py file.

jaraco added a commit that referenced this issue Mar 18, 2023
Add missing modules to packages_distributions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant