Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new option in cherry-picker config dict #639

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jackenmen
Copy link
Contributor

This will be necessary when python/cherry-picker#70 is merged. It would maybe be somewhat better to use cherry_picker.load_config() (or simply not specify the config which will default to the equivalent cherry_picker.DEFAULT_CONFIG) instead of hard-coding the configuration but I opted to just keep this consistent with what's already in the code base.

Since this project doesn't pin the version of cherry-picker, the merge of this will need to happen before the merge of the aforementioned PR. I haven't received feedback on the name of this config option though so I'm not entirely sure if it will stay like this.

@Jackenmen

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (820fcf4) to head (7bdf820).

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #639   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          357       357           
  Branches        29        14   -15     
=========================================
  Hits           357       357           
Flag Coverage Δ
Python_3.11 100.00% <ø> (ø)
Python_3.12 100.00% <ø> (ø)
Python_3.13 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants