Don't run flake8 twice in CI (#15129)

python · Apr 25, 2023 · 97e7f3e · 97e7f3e
1 parent 00f3913
commit 97e7f3e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -93,6 +93,9 @@ jobs:
  arch: x64
  os: windows-latest
  toxenv: type
+ # We also run these checks with pre-commit in CI,
+ # but it's useful to run them with tox too,
+ # to ensure the tox env works as expected
  - name: Formatting with Black + isort and code style with flake8
  python: '3.7'
  arch: x64

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -14,3 +14,7 @@ repos:
  additional_dependencies:
  - flake8-bugbear==22.12.6 # must match test-requirements.txt
  - flake8-noqa==1.3.0 # must match test-requirements.txt
+
+ci:
+ # We run flake8 as part of our GitHub Actions suite in CI
+ skip: [flake8]