Fix Enum final props and writable special members, refs #11820 (#11945

)
python · Jan 10, 2022 · f6ebf10 · f6ebf10
1 parent 6ea7cfa
commit f6ebf10
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/mypy/checker.py b/mypy/checker.py
@@ -2517,7 +2517,7 @@ def check_compatibility_final_super(self, node: Var,
             self.msg.cant_override_final(node.name, base.name, node)
             return False
         if node.is_final:
-            if base.fullname in ENUM_BASES and node.name in ENUM_SPECIAL_PROPS:
+            if base.fullname in ENUM_BASES or node.name in ENUM_SPECIAL_PROPS:
                 return True
             self.check_if_final_var_override_writable(node.name, base_node, node)
         return True

diff --git a/test-data/unit/check-enum.test b/test-data/unit/check-enum.test
@@ -1712,9 +1712,17 @@ class B(A): pass  # E: Cannot inherit from final class "A"
 
 [case testEnumFinalSpecialProps]
 # https://github.com/python/mypy/issues/11699
+# https://github.com/python/mypy/issues/11820
 from enum import Enum, IntEnum
 
-class E(Enum):
+class BaseWithSpecials:
+    __slots__ = ()
+    __doc__ = 'doc'
+    __module__ = 'module'
+    __annotations__ = {'a': int}
+    __dict__ = {'a': 1}
+
+class E(BaseWithSpecials, Enum):
     name = 'a'
     value = 'b'
     _name_ = 'a1'