version 0.930 regression: INTERNAL ERROR AttributeError: attribute 'arguments' of 'FuncDef' undefined #11899

arielf · 2022-01-04T21:24:24Z

Just sharing a regression I just hit on code that used to pass mypy before.

Unfortunately, updating from git is not an option in my env.

Line 273 in source I can't fully share is the first (def) line below which is one (override) method in a big class:

    def update(self,  # type: ignore
               name: Optional[str] = None,
               description: Optional[str] = None,
               metric: Optional[SyntheticObject] = None,
               category: Optional[UserDefinedObjectRequestcategoryEnum] = None,
               cacherefreshseconds: Optional[int] = None,
               refreshDataType: Optional[bool] = None,
               properties: Optional[ColumnParamsR] = None,
               keyEntity: Optional[str] = None,
               dataType: Optional[SomePrivateDataType] = None,
               initialCollection: Optional[str] = None) -> EntityProperty:

Stack trace when running mypy is:

.../entityproperty.py:273: error: INTERNAL ERROR -- Please try using mypy master on Github:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
Please report a bug at https://github.com/python/mypy/issues
version: 0.930
Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "mypy/checker.py", line 420, in accept
  File "mypy/nodes.py", line 727, in accept
  File "mypy/checker.py", line 770, in visit_func_def
  File "mypy/checker.py", line 781, in _visit_func_def
  File "mypy/checker.py", line 1469, in check_method_override
  File "mypy/checker.py", line 1497, in check_method_or_accessor_override_for_base
  File "mypy/checker.py", line 1583, in check_method_override_for_base_with_name
  File "mypy/checker.py", line 1745, in check_override
  File "mypy/messages.py", line 839, in signature_incompatible_with_supertype
  File "mypy/messages.py", line 861, in pretty_callable_or_overload
  File "mypy/messages.py", line 1937, in pretty_callable
AttributeError: attribute 'arguments' of 'FuncDef' undefined
.../entityproperty.py:273: : note: use --pdb to drop into pdb

The text was updated successfully, but these errors were encountered:

A5rocks · 2022-01-05T00:08:16Z

Looks to me like it's saying your class has a method (I assume this update method?) which is incompatible with the class it is inheriting from. And then, when it tries to print the superclass method, it... the superclass method isn't fully cached or something?

Not sure -- does clearing the cache fix this?

arielf · 2022-01-05T03:15:33Z

Thank you so much!

Confirming. Both of the below solutions worked for me:

Downgrade to mypy-0.920 while keeping the existing mypy cache

python3 -m pip install --user mypy==0.920

Upgrade back to mypy-0.930 AND clear the mypy cache:

python3 -m pip install --user mypy==0.930

rm -rf .mypy_cache

Thanks again. This comment was very helpful.

arielf · 2022-01-05T22:59:59Z

Sorry I have to take workaround (2) above back.

It solved the issue only for the 1st run (empty cache)

If I rerun mypy, even on a fresh cache (created by mypy-0.930) I get the INTERNAL ERROR again.

so the only real workaroud is (1) above: downgrade back to mypy-0.920

hauntsaninja · 2022-01-07T01:45:45Z

Okay, not fully minimal, but I think at least the following should get you a crash:

python -m pip install 'mypy==0.930' 'ray[default]==1.9.1' 'transformers==4.15.0' 'pytorch_lightning==1.5.3'
python -m mypy -c 'import ray; reveal_type((ray.get, ray.init, ray.remote))' --show-traceback --ignore-missing-imports --check-untyped-defs

A5rocks · 2022-01-07T02:25:30Z

I think @hauntsaninja's bug is #7045 -- though if it's a 0.930 regression then maybe not. (why'd I remember this? Cause I noticed the transformers install though I doubt that's why :^)

hauntsaninja · 2022-01-07T02:57:14Z

Nice spot! Yeah, that should account for the second stacktrace. The first stacktrace, which is what the repro gives is #10521 and #9081 . It is not a regression since 0.930, I just got fooled by the timing of it popping up in this codebase. Sorry for cluttering up this issue!

fperrin · 2022-03-09T18:14:23Z

I believe I have a small repro case for this internal crash:

mkdir app
touch app/__init__.py
cat > app/a.py <<EOF
class Foo:
    def frobnicate(self, *args, **kwargs): pass
EOF

cat > app/b.py <<EOF
from app.a import Foo
class Bar(Foo):
    def frobnicate(self) -> None: pass
EOF

Then run mypy -m app.b twice. The first one will fail with Signature of "frobnicate" incompatible with supertype as expected, the second time triggers an INTERNAL ERROR:

(3.9.4-devtools) fperrin-laptop:/tmp/repro-11899% mypy -m app.b
app/b.py:3: error: Signature of "frobnicate" incompatible with supertype "Foo"
app/b.py:3: note:      Superclass:
app/b.py:3: note:          def frobnicate(self, *args: Any, **kwargs: Any) -> Any
app/b.py:3: note:      Subclass:
app/b.py:3: note:          def frobnicate(self) -> None
Found 1 error in 1 file (checked 1 source file)
zsh: exit 1     mypy -m app.b
(3.9.4-devtools) fperrin-laptop:/tmp/repro-11899% mypy -m app.b
app/b.py:3: error: Signature of "frobnicate" incompatible with supertype "Foo"
app/b.py:3: note:      Superclass:
/private/tmp/repro-11899/app/b.py:3: error: INTERNAL ERROR -- Please try using mypy master on Github:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
If this issue continues with mypy master, please report a bug at https://github.com/python/mypy/issues
version: 0.950+dev.4a744b35e28277e2193feb78de90d3b3cbb3169b
/private/tmp/repro-11899/app/b.py:3: : note: please use --show-traceback to print a traceback when reporting a bug
zsh: exit 2     mypy -m app.b

I just tried with version: 0.950+dev.4a744b35e28277e2193feb78de90d3b3cbb3169b.

Minimum reproduction of issue python#11899. The second iteration of that incremental test fails with: b.py:3: error: INTERNAL ERROR -- Please try using mypy master on Github: [ ... ] Dropping into pdb > mypy/messages.py(1951)pretty_callable() -> definition_args = [arg.variable.name for arg in tp.definition.arguments] (Pdb) p type(tp.definition) <class 'mypy.nodes.FuncDef'> (Pdb) p tp.definition.arguments *** AttributeError: arguments

This is a partial revert of d180456. Resolves python#11899

When FuncDef is deserialized we don't reconstruct the arguments. Previous code was deleting the attribute, leading to python#11899; instead, always set the attribute, maybe to None, and mypy can remind us to check for not None before use.

KotlinIsland · 2022-05-20T09:25:45Z

This looks like a duplicate of #11449

When FuncDef is deserialized we don't reconstruct the arguments. Previous code was deleting the attribute, leading to python#11899; instead, always set the attribute, maybe to None, and mypy can remind us to check for not None before use.

When FuncDef is deserialized we don't reconstruct the arguments. Previous code was deleting the attribute, leading to python#11899; instead, always set the attribute, maybe to the empty list, and get argument names from arg_names if arguments is empty.

fperrin · 2022-05-20T10:56:05Z

This looks like a duplicate of #11449

It does indeed. I have a proposed fix in #12324, I need to rebase because after recent changes to mypy master.

When FuncDef is deserialized we don't reconstruct the arguments. Previous code was deleting the attribute, leading to python#11899; instead, always set the attribute, maybe to the empty list, and get argument names from arg_names if arguments is empty.

AlexWaygood · 2022-05-27T17:52:06Z

Since we upgraded to mypy 0.960 over at typeshed, I now (for some reason) hit this crash every time I run mypy_test.py twice in a row locally. It's always the exact same traceback as in this issue, and it always occurs when mypy runs on our Flask-SQLAlchemy stubs.

When FuncDef is deserialized we don't reconstruct the arguments. Previous code was deleting the attribute, leading to python#11899; instead, always set the attribute, maybe to the empty list, and get argument names from arg_names if arguments is empty.

hauntsaninja · 2022-06-29T12:28:13Z

Should be fixed by #12324. Let me know if anyone has a repro of bad behaviour against current master. And thanks again to @fperrin for finding a minimal repro and making a fix!

JukkaL mentioned this issue Jan 5, 2022

Release 0.930 planning #11700

Closed

This comment has been minimized.

Sign in to view

97littleleaf11 added the crash label Jan 16, 2022

fperrin added a commit to fperrin/mypy that referenced this issue Mar 9, 2022

Don't use tp.definition.arguments in pretty_callable

b1e73de

This is a partial revert of d180456. Resolves python#11899

fperrin mentioned this issue Mar 10, 2022

"AttributeError: attribute 'arguments' of 'FuncDef' undefined" when running mypy twice #12324

Merged

AlexWaygood mentioned this issue May 28, 2022

mypy_test.py: Skip Flask-SQLAlchemy python/typeshed#7977

Merged

AlexWaygood mentioned this issue Jun 17, 2022

Internal Error from using BigQuery Google Cloud library #12994

Closed

hauntsaninja closed this as completed Jun 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

version 0.930 regression: INTERNAL ERROR AttributeError: attribute 'arguments' of 'FuncDef' undefined #11899

version 0.930 regression: INTERNAL ERROR AttributeError: attribute 'arguments' of 'FuncDef' undefined #11899

arielf commented Jan 4, 2022

A5rocks commented Jan 5, 2022

arielf commented Jan 5, 2022

arielf commented Jan 5, 2022

This comment has been minimized.

hauntsaninja commented Jan 7, 2022

A5rocks commented Jan 7, 2022 •

edited

Loading

hauntsaninja commented Jan 7, 2022 •

edited

Loading

fperrin commented Mar 9, 2022

KotlinIsland commented May 20, 2022 •

edited

Loading

fperrin commented May 20, 2022

AlexWaygood commented May 27, 2022

hauntsaninja commented Jun 29, 2022

version 0.930 regression: INTERNAL ERROR AttributeError: attribute 'arguments' of 'FuncDef' undefined #11899

version 0.930 regression: INTERNAL ERROR AttributeError: attribute 'arguments' of 'FuncDef' undefined #11899

Comments

arielf commented Jan 4, 2022

A5rocks commented Jan 5, 2022

arielf commented Jan 5, 2022

arielf commented Jan 5, 2022

This comment has been minimized.

hauntsaninja commented Jan 7, 2022

A5rocks commented Jan 7, 2022 • edited Loading

hauntsaninja commented Jan 7, 2022 • edited Loading

fperrin commented Mar 9, 2022

KotlinIsland commented May 20, 2022 • edited Loading

fperrin commented May 20, 2022

AlexWaygood commented May 27, 2022

hauntsaninja commented Jun 29, 2022

A5rocks commented Jan 7, 2022 •

edited

Loading

hauntsaninja commented Jan 7, 2022 •

edited

Loading

KotlinIsland commented May 20, 2022 •

edited

Loading