Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert LteralString support from vendored typeshed copy #13091

Closed
ilevkivskyi opened this issue Jul 8, 2022 · 0 comments · Fixed by #13093
Closed

Revert LteralString support from vendored typeshed copy #13091

ilevkivskyi opened this issue Jul 8, 2022 · 0 comments · Fixed by #13093
Labels
affects-typeshed Anything that blocks a typeshed change bug mypy got something wrong priority-0-high

Comments

@ilevkivskyi
Copy link
Member

We don't properly support LteralString anyway, so its use in typeshed causes some false positives. We need to locally revert python/typeshed#7725 for now.
@ilevkivskyi ilevkivskyi added bug mypy got something wrong priority-0-high affects-typeshed Anything that blocks a typeshed change labels Jul 8, 2022
This was referenced Jul 8, 2022
Closed
Merged
JukkaL pushed a commit that referenced this issue Jul 8, 2022
@ilevkivskyi
Remove use of LiteralString in builtins (#13093)
ce891e3 
Fixes #13091

Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
hauntsaninja pushed a commit to hauntsaninja/mypy that referenced this issue Jul 8, 2022
@ilevkivskyi
Remove use of LiteralString in builtins (python#13093)
bb38db9 
Fixes python#13091

Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
@hauntsaninja hauntsaninja mentioned this issue Jul 16, 2022
Open
ilevkivskyi added a commit to ilevkivskyi/mypy that referenced this issue Jul 27, 2022
@ilevkivskyi
Remove use of LiteralString in builtins (python#13093)
b8ec4da 
Fixes python#13091

Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
Gobot1234 pushed a commit to Gobot1234/mypy that referenced this issue Aug 12, 2022
@ilevkivskyi @Gobot1234
Remove use of LiteralString in builtins (python#13093)
b6d4016 
Fixes python#13091

Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
jhance pushed a commit that referenced this issue Aug 17, 2022
@ilevkivskyi @jhance
Remove use of LiteralString in builtins (#13093)
6bc2771 
Fixes #13091

Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
emmatyping added a commit that referenced this issue Aug 20, 2022
@emmatyping
Remove use of LiteralString in builtins
0be6865 
Fixes #13091

Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-typeshed Anything that blocks a typeshed change bug mypy got something wrong priority-0-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of LiteralString in builtins ilevkivskyi/mypy
1 participant
@ilevkivskyi