Skip to content

[BLOCKER] Effect of '# type: ignore' became much more severe after '--warn-unused-ignores' #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gvanrossum opened this issue Jul 19, 2016 · 1 comment · Fixed by #1912
Closed

[BLOCKER] Effect of '# type: ignore' became much more severe after '--warn-unused-ignores' #1911

gvanrossum opened this issue Jul 19, 2016 · 1 comment · Fixed by #1912
Labels
bug mypy got something wrong

Comments

@gvanrossum
Copy link
Member

It seems the introduction of --warn-unused-ignores in 4889c0c caused even valid imports to acquire the type Any.
@gvanrossum gvanrossum added the bug mypy got something wrong label Jul 19, 2016
@gvanrossum gvanrossum added this to the 0.4.x milestone Jul 19, 2016
@gvanrossum gvanrossum mentioned this issue Jul 19, 2016
Closed
@gvanrossum gvanrossum changed the title Effect of '# type: ignore' became much more severe after '--warn-unused-ignores' [BLOCKER] Effect of '# type: ignore' became much more severe after '--warn-unused-ignores' Jul 19, 2016
@gvanrossum gvanrossum mentioned this issue Jul 19, 2016
Closed
@Michael0x2a
Copy link
Collaborator

It seems like there's some disagreement over the expected behavior of the first test case (testIgnoreImportBadModule) introduced by d379a93 -- if a module is marked as # type: ignore, it should only ignore errors if that module does not exist, and not if there's any error of any kind from within that module.

@Michael0x2a Michael0x2a mentioned this issue Jul 19, 2016
Merged
@gvanrossum gvanrossum mentioned this issue Jul 19, 2016
Merged
gvanrossum pushed a commit that referenced this issue Jul 19, 2016
@Michael0x2a @gvanrossum
Make mypy still check imports with # type: ignore comments if the i…
a0eadce 
…mport exists (#1912)

Fixes #1911; also incidentally fixes #1904.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mypy got something wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make mypy still check imports with # type: ignore comments if the import exists Michael0x2a/mypy
2 participants
@Michael0x2a @gvanrossum