Skip to content

Fine-grained: Failure to propagate change when import changes to another class #4600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JukkaL opened this issue Feb 20, 2018 · 1 comment
Closed
Labels

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Feb 20, 2018

This fine-grained incremental mode test case fails (no errors generated):

[case testIndirectAnnotationChange]
import a
from c import A
a.f(A())
[file a.py]
from b import A
def f(x: A) -> None: pass
[file b.py]
from c import A
[file b.py.2]
from d import A
[file c.py]
class A: pass
[file d.py]
class A: pass
[out]
==
main:3: error: Argument 1 to "f" has incompatible type "c.A"; expected "d.A"

My hypothesis is that this is caused by there being no dependency from a.A to a.f. #4598 might also needed to fix this (but it's not sufficient).

@JukkaL JukkaL added bug mypy got something wrong topic-fine-grained-incremental labels Feb 20, 2018
@msullivan
Copy link
Collaborator

Duplicate of #4512

@msullivan msullivan marked this as a duplicate of #4512 Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants