-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Stop supporting Python 3.4 to run mypy #6564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 from me. Some PRs fail on 3.4 because it has some syntax limitations, I think the latest example is Michael's union PR. |
Let's do this. I think that mypyc doesn't support 3.4. This means that once we ship a mypyc-compiled mypy by default, we should either drop 3.4 support or add Python 3.4 support to mypyc. The latter seems pointless because of the EoL, so dropping 3.4 support seems to make the most sense from this point of view as well. |
Apologies, fat fingered. I am about ready with a PR. |
Python 3.4 has reached its end of life: https://mail.python.org/pipermail/python-dev/2019-March/156705.html
We can still support targeting it with
--python-version 3.4
, but we should no longer feel bound to support running mypy with 3.4.The text was updated successfully, but these errors were encountered: