Skip to content

Stop supporting Python 3.4 to run mypy #6564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gvanrossum opened this issue Mar 18, 2019 · 3 comments
Closed

Stop supporting Python 3.4 to run mypy #6564

gvanrossum opened this issue Mar 18, 2019 · 3 comments
Assignees

Comments

@gvanrossum
Copy link
Member

Python 3.4 has reached its end of life: https://mail.python.org/pipermail/python-dev/2019-March/156705.html

We can still support targeting it with --python-version 3.4, but we should no longer feel bound to support running mypy with 3.4.

@ilevkivskyi
Copy link
Member

+1 from me. Some PRs fail on 3.4 because it has some syntax limitations, I think the latest example is Michael's union PR.

@JukkaL
Copy link
Collaborator

JukkaL commented Mar 19, 2019

Let's do this.

I think that mypyc doesn't support 3.4. This means that once we ship a mypyc-compiled mypy by default, we should either drop 3.4 support or add Python 3.4 support to mypyc. The latter seems pointless because of the EoL, so dropping 3.4 support seems to make the most sense from this point of view as well.

@emmatyping emmatyping self-assigned this Mar 26, 2019
@emmatyping emmatyping reopened this Mar 26, 2019
@emmatyping
Copy link
Member

Apologies, fat fingered. I am about ready with a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants