Skip to content

TypeJoinVisitor doesn't support visit_overloaded() #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JamesGuthrie opened this issue Jul 27, 2015 · 2 comments
Closed

TypeJoinVisitor doesn't support visit_overloaded() #729

JamesGuthrie opened this issue Jul 27, 2015 · 2 comments
Labels
bug mypy got something wrong

Comments

@JamesGuthrie
Copy link
Contributor

I'm still experimenting with #638, I have made some progress, but seem to have stumbled across a mypy bug with my test case. The type checker fails because the type Overloaded is not handled by the TypeJoinVisitor. How should the Overloaded type be joined with other types?

@JukkaL JukkaL added the bug mypy got something wrong label Aug 4, 2015
@JukkaL
Copy link
Collaborator

JukkaL commented Aug 4, 2015

Hmm... I started thinking about this and it's about as easy (or difficult) to implement this as to specify how it would work. I hope to have an implementation ready in a couple of days, but this is actually pretty subtle if we want to deal correctly with Any types, etc.

@JukkaL JukkaL closed this as completed in 6fc0dc7 Aug 17, 2015
@JukkaL
Copy link
Collaborator

JukkaL commented Aug 17, 2015

Finally got around to fixing this. Please let me know if the fix works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mypy got something wrong
Projects
None yet
Development

No branches or pull requests

2 participants