Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.750 planning #7947

Closed
ilevkivskyi opened this issue Nov 13, 2019 · 13 comments
Closed

Release 0.750 planning #7947

ilevkivskyi opened this issue Nov 13, 2019 · 13 comments
Assignees

Comments

@ilevkivskyi
Copy link
Member

I am planning to release mypy v0.750 next Thursday, November 21. The release branch will be cut on Monday, November 18. Please add any PRs you want to be merged/cherry-picked here.

I think we need to land #7921 (I assume there will be also a second part) and also #7169 (or its successor, mostly because it completes the tagged unions).

Also we have two big plugin breakers in flight: #7829 and #7923. I think it is probably best to include only one of them in the release. I am fine with either one (btw I tried the type alias one against internal repos and it caused no problems except for breaking one of the plugins).

@msullivan
Copy link
Collaborator

On the flip-side, maybe it's better to include both so people don't need to fix it two releases in a row?

@ilevkivskyi
Copy link
Member Author

On the flip-side, maybe it's better to include both so people don't need to fix it two releases in a row?

Hm, interesting point. Maybe this makes sense. @JukkaL what do you think?

@ilevkivskyi
Copy link
Member Author

OK, after some more thinking, it seems to me breaking it once is probably better, so I am going to merge the other PR now.

@isac322
Copy link

isac322 commented Nov 15, 2019

I think it would be good if #7789 could be added to the release. Thank you 👍

@JelleZijlstra
Copy link
Member

@isac322 it's already merged in, so it will be included in the release (barring something going wrong).

@Michael0x2a
Copy link
Collaborator

Sorry, it doesn't seem like I'm going to be able to get #7169 / a successor to that diff working in time for today's cutoff. I feel I have something that's almost working apart from one or two issues -- but every time I try fixing one of those issues, another one pops up...

Best case scenario, I think it'll probably take me somewhere between two days to another week to get everything ironed out and ready for an initial code review?

I'm not sure if it's worth delaying 0.750 for this though -- we can always announce tagged unions in the next release.

@ilevkivskyi
Copy link
Member Author

I'm not sure if it's worth delaying 0.750 for this though -- we can always announce tagged unions in the next release.

OK, we should just not forget it wasn't announced in 0.750 when releasing the next version. Be sure to give the PR a prominent title.

@ilevkivskyi
Copy link
Member Author

There were couple delays, the new planned release date is Thursday, November 28.

@ilevkivskyi
Copy link
Member Author

The 0.750 release branch is now cut at 2af0ac0.

@ilevkivskyi
Copy link
Member Author

OK, the release just went out.

@JelleZijlstra
Copy link
Member

Should there be a 0.751 release with the fix for #8051?

I would like one because #8051 caused a fair number of new false positives in our code, so we're sticking with 0.740 for now.

@ilevkivskyi
Copy link
Member Author

The next release 0.760 is planned for December 17. Can you wait until then or do you really want a point release sooner?

@JelleZijlstra
Copy link
Member

Waiting should be fine, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants