[mypyc] Raise ImportError instead of AttributeError when from-import fails #10641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
reviewed
Jun 14, 2021
|
@msullivan Thanks for your review! I will fix those tests later. |
JukkaL
reviewed
Jun 14, 2021
mypyc/lib-rt/misc_ops.c
Outdated
| } | ||
|
|
||
| // The following code is a simplification of cpython/import.c/PyImport_GetModule() | ||
| Py_INCREF(module); |
There was a problem hiding this comment.
This incref and the decref below seem redundant, since the caller will continue to hold a reference to these.
|
Actually, this may be missing a test. You should validate that you get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes mypyc/mypyc#707
Test Plan