WIP: adds better namedtuple semantic analyzer
#11206
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This PR would also help us a lot: python/typeshed#6080 Since we now typecheck |
sobolevn
added a commit
to sobolevn/optuna
that referenced
this pull request
Sep 27, 2021
The best practice is to match `typename` with variable name. For example, `mypy` reports any other usages as errors: python/mypy#11206 (comment)
sobolevn
added a commit
to sobolevn/paasta
that referenced
this pull request
Sep 27, 2021
The best practice is to match `typename` with variable name. For example, `mypy` reports any other usages as errors: python/mypy#11206 (comment)
This comment has been minimized.
This comment has been minimized.
nemacysts
pushed a commit
to Yelp/paasta
that referenced
this pull request
Sep 29, 2021
The best practice is to match `typename` with variable name. For example, `mypy` reports any other usages as errors: python/mypy#11206 (comment)
This was referenced Oct 9, 2021
Merged
sobolevn
added a commit
to sobolevn/manticore
that referenced
this pull request
Nov 7, 2021
I am working on new `mypy` feature and it identified a problem with your `namedtuple` definitions. python/mypy#11206 (comment) By standard first string arg should match variable name.
|
I finally have the time to continue my work! All PRs that I needed: python/typeshed#6080 / #11303 / #11162 are merged! |
This comment has been minimized.
This comment has been minimized.
|
All |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ekilmer
pushed a commit
to trailofbits/manticore
that referenced
this pull request
Nov 8, 2021
I am working on new `mypy` feature and it identified a problem with your `namedtuple` definitions. python/mypy#11206 (comment) By standard first string arg should match variable name.
This comment has been minimized.
This comment has been minimized.
6 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sobolevn
added a commit
to sobolevn/manticore
that referenced
this pull request
Dec 4, 2021
While working on python/mypy#11206 I found that `Regspec` definition is not ideal. It is recommended to use the same string name, as variable name. For example, it affects how `pickle` works. Related trailofbits#2501 Related trailofbits@6e036f3
ekilmer
pushed a commit
to trailofbits/manticore
that referenced
this pull request
Dec 5, 2021
While working on python/mypy#11206 I found that `Regspec` definition is not ideal. It is recommended to use the same string name, as variable name. For example, it affects how `pickle` works. Related #2501 Related 6e036f3
|
You might use |
|
@97littleleaf11 thank you! Can you please be more specific? 🙂 |
|
@sobolevn You can just replace |
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/frame.py:1402: error: Unused "type: ignore" comment
+ pandas/core/frame.py:1403: error: "namedtuple()" expects a string literal as the typename argument [misc]
|
|
Awesome, thank you, @97littleleaf11 I will add more tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost a complete rewrite of inline
NamedTupleandnamedtuplesemantic analyzer.Changelog:
NamedTuplenow supports**kwargsas it shouldNamedTupleandnamedtuplenow have better validation for fields: keywords, underscores, duplication: basically the same ascollections.namedtupledoes at runtimenamedtuplenow supportsrenameargument (it actually renames invalid fields)NamedTuple()andnamedtuple()calls during typechecking, this allows us to simplify the setupbytesare valid arguments onpython3NamedTupleandnamedtuplenow support named arguments as they shouldsemanal.pydoes not raise any namedtuple-expr-related errorscollections.namedtuple, added""everywhereThis is still WIP, but I've wrote several tests for this in
testsemanal.py. They are passing. Andselfcheck also passes.I can continue to work on this after #11162 is merged or rejected. Because I need better typing fixtures for
NamedTupletype.Closes #11047