Do not auto-infer TypeGuard
return type for lambda
, refs #9927
#11417
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's what was happening in this example:
Mypy uses special logic in
infer_lambda_type_using_context
to inferlambda
type args and return type. Basically, it just returns the current callable context type. Which isCallable[[T], TypeGuard[R]]
in our case.But, now I've limited this function to ignore contexts with
TypeGuard
. Because I believe thatTypeGuard
must always be explicit.After this change Mypy works correctly:
Because we don't allow
bool
return type whereTypeGuard
is expected after #11314The test from @gvanrossum that used to be skipped now passes 🎉
Closes #9927