Handle raise Exception(), None on Python2.7
#11786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
commented
Dec 18, 2021
mypy/checker.py
Outdated
Comment on lines
3552
to
3556
| if (len(typ.items) >= 2 | ||
| and isinstance(get_proper_type(typ.items[1]), NoneType)): | ||
| expected_type = exc_inst_or_type | ||
| else: | ||
| expected_type = TypeType(exc_type) |
There was a problem hiding this comment.
This part has changed compared to the original PR, CC @JukkaL
|
Note that import sys
t = None
try:
1 / 0
except ZeroDivisionError as e:
_, _, t = sys.exc_info()
print('done', type(t))
raise Exception(), None, tTry it online: https://paiza.io/projects/e/fX6oV85YpCzoXIWv5h-pmw |
JukkaL
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope that this time we've covered everything 🙂
Closes #11742
Related #11743
Related #11289
Related #11700