fix: do not crash if "_" is parsed in builtins #11811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows the definiton of "_" as function in builtins (e.g via typeshed). fixes issue python#9802
sobolevn
reviewed
Dec 21, 2021
| @@ -4296,7 +4296,7 @@ def lookup(self, name: str, ctx: Context, | |||
| assert isinstance(b.node, MypyFile) | |||
| table = b.node.names | |||
| if name in table: | |||
| if name[0] == "_" and name[1] != "_": | |||
| if len(name) > 1 and name[0] == "_" and name[1] != "_": | |||
There was a problem hiding this comment.
Question: why would we need to define _ as a function in __builtins__? There's no such function as far as I remember.
The original issue was about a custom module, not __builtins__.
There was a problem hiding this comment.
It's a standard pattern: https://docs.python.org/3/library/gettext.html#gettext.install
|
Thank you! (I was happy to merge without a dedicated test, not really worth a custom builtins stub) |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
allows the definition of "_" as function in builtins (e.g via typeshed). fixes python#9802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows the definiton of "_" as function in builtins (e.g via typeshed).
fixes issue #9802
Description
Fixes #9802
Test Plan