Fix regression when a contextmanager yields a generic #11870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #11852
I had to back out some of the tests added in the patch which regressed this behaviour -- once I had "fixed" them they were identical to existing tests
I added a new test to cover the behaviour that had regressed. I had to simplify it a bit from the one in the issue due to missing fixtures
Test Plan
automated tests in the patch itself -- the added test fails on master: