Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI by allowing it to fail on 3.11 #12003

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Fix CI by allowing it to fail on 3.11 #12003

merged 2 commits into from
Jan 18, 2022

Conversation

sobolevn
Copy link
Member

Closes #12002
Refs #11984

@sobolevn sobolevn changed the title Update test.yml Fix CI by allowing it to fail on 3.11 Jan 17, 2022
@sobolevn sobolevn mentioned this pull request Jan 17, 2022
@sobolevn
Copy link
Member Author

It does not fail anymore, but is still broken: https://github.com/python/mypy/runs/4844006633?check_suite_focus=true

@sobolevn
Copy link
Member Author

CC other CI committers: @hauntsaninja @97littleleaf11 @ethanhs

This problem blocks other PRs to be merged. We have several options:

  1. This
  2. Remove 3.11 (I don't want to do that, because of how radical it is)
  3. Try to fix cpython / typed-ast (might be a long process)

@97littleleaf11
Copy link
Collaborator

The first two options are the same - they skip all the tests on Python 3.11. I prefer droping python nightly test for a while and just wait for fix on typed-ast.

@JukkaL
Copy link
Collaborator

JukkaL commented Jan 18, 2022

I agree with @97littleleaf11. I think that it's best to disable Python nightly temporarily while typed-ast is broken.

@sobolevn
Copy link
Member Author

Done! Thanks everyone! 👍

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JukkaL JukkaL merged commit 9b31477 into master Jan 18, 2022
@JukkaL JukkaL deleted the fixes-ci-tox-typed-ast branch January 18, 2022 13:07
KotlinIsland pushed a commit to KotlinIsland/basedmypy that referenced this pull request Jan 19, 2022
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
KotlinIsland pushed a commit to KotlinIsland/basedmypy that referenced this pull request Jan 21, 2022
KotlinIsland pushed a commit to KotlinIsland/basedmypy that referenced this pull request Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants