Fix caching of PEP 561 namespace packages with missing submodules #12250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Fixes python#12232 Another "fail every 2nd run" bug
hauntsaninja
force-pushed
the
561cach
branch
from
bfeae2c
to
d682434
Compare
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: pyinstrument (https://github.com/joerick/pyinstrument)
- pyinstrument/vendor/appdirs.py:533: error: Cannot find implementation or library stub for module named "com.sun"
+ pyinstrument/vendor/appdirs.py:562: error: Cannot find implementation or library stub for module named "com.sun"
|
hauntsaninja
commented
Feb 24, 2022
| @@ -415,9 +415,9 @@ follow_imports = error | |||
| [file a.py] | |||
| / # No error reported | |||
| [out] | |||
| main.py:1: error: Import of "a" ignored | |||
| main.py:1: note: (Using --follow-imports=error, module not passed on command line) | |||
| main.py:2: note: Revealed type is "Any" | |||
There was a problem hiding this comment.
This actually makes it match the comments in the test case
|
Seems like no takers on reviews, so I'm going to go ahead and merge. Any fixes for namespace packages are probably really good to get in ahead of #9636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12232
Another "fail every 2nd run" bug
if not self.is_module(sub_id):, the parent can come before another child, and we fail to resolve the parent.