Do not generate __match_args__ when running with --python-version < 3.10
#12503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@stkrizh This looks good, and should be ready to land once there are no merge conflicts. (And sorry for the slow review!) |
|
@JukkaL Thank you, no problem. I will update the PR soon. |
…n running with `--python-version` < 3.10
stkrizh
force-pushed
the
match-args-old-python-versions
branch
from
3eed98a
to
5024752
Compare
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Gobot1234
pushed a commit
to Gobot1234/mypy
that referenced
this pull request
Aug 12, 2022
…on-version < 3.10 (python#12503) Fixes python#12489
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes autogeneration of
__match_args__attribute for dataclasses and named tuples when running with--python-versionset to < 3.10Fixes #12489