Improve error message for partial None with --local-partial-types
#12822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggest an annotation of the form
Optional[<type>]
when we show an error for an inferred partialNone
type (which I think should only happen when--local-partial-types
is set).Should help with merging #10169 (see #10169 (comment)).
Test Plan
The error message in question appeared in a few tests which got changed. I think that should be sufficient to test this since this isn't a particularly complicated change.