Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some Python 2 configuration #13258

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Clean up some Python 2 configuration #13258

merged 3 commits into from
Jul 28, 2022

Conversation

hauntsaninja
Copy link
Collaborator

Linking #12237

JelleZijlstra
JelleZijlstra reviewed Jul 28, 2022
View reviewed changes
test-data/unit/cmdline.test
@@ -643,7 +625,7 @@ python_version = 4.0
mypy.ini: [mypy]: python_version: Python major version '4' out of range (must be 2 or 3)
== Return code: 0

[case testPythonVersionAccepted27]
[case testPythonVersionTooDead27]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit e2fb448 into python:master Jul 28, 2022
@hauntsaninja hauntsaninja deleted the py2-config branch July 28, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauntsaninja @JelleZijlstra