Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python2 extra from setup.py #13269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sobolevn
Copy link
Member

Refs #12237

@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja
Copy link
Collaborator

I'm not sure about this... If we keep the extra around, users will get a much more helpful error at type check time, rather than a sort of mysterious install time failure.

My vote would be to clean this up a couple of releases from now.

@sobolevn
Copy link
Member Author

Ok, fair enough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants