Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable testFlagsFile #13479

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Reenable testFlagsFile #13479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a458b09
Reenable `testFlagsFile`, refs #13241
sobolevn Aug 22, 2022
7c42db7
Update cmdline.test
sobolevn Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions test-data/unit/cmdline.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,17 +130,13 @@ two/mod/__init__.py: note: See https://mypy.readthedocs.io/en/stable/running_myp
two/mod/__init__.py: note: Common resolutions include: a) using `--exclude` to avoid checking one of them, b) adding `__init__.py` somewhere, c) using `--explicit-package-bases` or adjusting MYPYPATH
== Return code: 2

[case testFlagsFile-skip]
-- Note that we use `----`, because this is how `--` is escaped while `--` is a comment starter.
[case testFlagsFile]
# cmd: mypy @flagsfile
[file flagsfile]
--always-true=FLAG
----always-true=FLAG
main.py
[file main.py]
# TODO: this test case passes if you try the exact same thing
# outside of the test suite. what's going on? it's not related
# to the extra flags that testcmdline adds. and things work
# in the test suite with py2 (perhaps because it's a
# special option)
x: int
FLAG = False
if not FLAG:
Expand Down