[mypyc] Track definedness of native int attributes using a bitmap #13532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since native ints can't support a reserved value to mark an undefined attribute, use a separate bitmap attribute (or attributes) to store information about defined/undefined attributes with native int types. The bitmap is only defined if we can't infer that an attribute is always defined, and it's only needed for native int attributes. We only access the bitmap if the runtime value of an attribute is equal to the (overlapping) error value. This way the performance cost of the bitmap is pretty low on average. I'll add support for traits in a follow-up PR to keep this PR simple. Work on mypyc/mypyc#837.
jhance
approved these changes
Aug 31, 2022
jhance
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since native ints can't support a reserved value to mark an undefined
attribute, use a separate bitmap attribute (or attributes) to store
information about defined/undefined attributes with native int types.
The bitmap is only defined if we can't infer that an attribute is
always defined, and it's only needed for native int attributes.
We only access the bitmap if the runtime value of an attribute is
equal to the (overlapping) error value. This way the performance cost
of the bitmap is pretty low on average.
I'll add support for traits in a follow-up PR to keep this PR simple.
Work on mypyc/mypyc#837.