Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat ABCMeta subtypes as abstract metaclasses #13562

Merged
merged 2 commits into from
Sep 3, 2022

Conversation

sobolevn
Copy link
Member

Closes #13561

@sobolevn sobolevn changed the title Treat ABCMeta subtypes and abstract metaclasses Treat ABCMeta subtypes as abstract metaclasses Aug 31, 2022
@github-actions

This comment has been minimized.

@sobolevn
Copy link
Member Author

All CI failures are unrelated, I've already seen this today in https://github.com/python/mypy/actions/runs/2961189292/attempts/1

CC @AlexWaygood

@AlexWaygood
Copy link
Member

AlexWaygood commented Aug 31, 2022

All CI failures are unrelated, I've already seen this today in https://github.com/python/mypy/actions/runs/2961189292/attempts/1

CC @AlexWaygood

I've no idea if #13547 is causing the problems, but #13564 is a PR to revert #13547 :) Maybe it fixes things. (EDIT: It didn't; the CI failures must be caused by something else.)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@sobolevn
Copy link
Member Author

sobolevn commented Sep 3, 2022

Going to merge this as quite simple :)

@sobolevn sobolevn merged commit fd2d684 into python:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABCMeta and its subclasses are treated differently
3 participants