Use a dedicated error code for abstract type object type error #13785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: Tanjun (https://github.com/FasterSpeeding/Tanjun)
- tanjun/permissions.py:167: error: Only concrete class can be given where "Type[AsyncCache[Union[Snowflake, int], GuildChannel]]" is expected [misc]
+ tanjun/permissions.py:167: error: Only concrete class can be given where "Type[AsyncCache[Union[Snowflake, int], GuildChannel]]" is expected [type-abstract]
- tanjun/permissions.py:222: error: Only concrete class can be given where "Type[AsyncCache[Union[Snowflake, int], Guild]]" is expected [misc]
+ tanjun/permissions.py:222: error: Only concrete class can be given where "Type[AsyncCache[Union[Snowflake, int], Guild]]" is expected [type-abstract]
- tanjun/permissions.py:241: error: Only concrete class can be given where "Type[GuildBoundCache[Union[Snowflake, int], Role]]" is expected [misc]
+ tanjun/permissions.py:241: error: Only concrete class can be given where "Type[GuildBoundCache[Union[Snowflake, int], Role]]" is expected [type-abstract]
- tanjun/permissions.py:335: error: Only concrete class can be given where "Type[AsyncCache[Union[Snowflake, int], Role]]" is expected [misc]
+ tanjun/permissions.py:335: error: Only concrete class can be given where "Type[AsyncCache[Union[Snowflake, int], Role]]" is expected [type-abstract]
- tanjun/dependencies/owners.py:172: error: Only concrete class can be given where "Type[SingleStoreCache[Application]]" is expected [misc]
+ tanjun/dependencies/owners.py:172: error: Only concrete class can be given where "Type[SingleStoreCache[Application]]" is expected [type-abstract]
- tanjun/dependencies/limiters.py:513: error: Only concrete class can be given where "Type[AbstractCooldownManager]" is expected [misc]
+ tanjun/dependencies/limiters.py:513: error: Only concrete class can be given where "Type[AbstractCooldownManager]" is expected [type-abstract]
- tanjun/dependencies/limiters.py:865: error: Only concrete class can be given where "Type[AbstractConcurrencyLimiter]" is expected [misc]
+ tanjun/dependencies/limiters.py:865: error: Only concrete class can be given where "Type[AbstractConcurrencyLimiter]" is expected [type-abstract]
- tanjun/dependencies/__init__.py:112: error: Only concrete class can be given where "Type[AbstractOwners]" is expected [misc]
+ tanjun/dependencies/__init__.py:112: error: Only concrete class can be given where "Type[AbstractOwners]" is expected [type-abstract]
- tanjun/clients.py:754: error: Only concrete class can be given where "Type[Client]" is expected [misc]
+ tanjun/clients.py:754: error: Only concrete class can be given where "Type[Client]" is expected [type-abstract]
- tanjun/clients.py:757: error: Only concrete class can be given where "Type[RESTClient]" is expected [misc]
+ tanjun/clients.py:757: error: Only concrete class can be given where "Type[RESTClient]" is expected [type-abstract]
- tanjun/clients.py:759: error: Only concrete class can be given where "Type[Cache]" is expected [misc]
+ tanjun/clients.py:759: error: Only concrete class can be given where "Type[Cache]" is expected [type-abstract]
- tanjun/clients.py:761: error: Only concrete class can be given where "Type[EventManager]" is expected [misc]
+ tanjun/clients.py:761: error: Only concrete class can be given where "Type[EventManager]" is expected [type-abstract]
- tanjun/clients.py:763: error: Only concrete class can be given where "Type[InteractionServer]" is expected [misc]
+ tanjun/clients.py:763: error: Only concrete class can be given where "Type[InteractionServer]" is expected [type-abstract]
- tanjun/clients.py:765: error: Only concrete class can be given where "Type[ShardAware]" is expected [misc]
+ tanjun/clients.py:765: error: Only concrete class can be given where "Type[ShardAware]" is expected [type-abstract]
- tanjun/clients.py:767: error: Only concrete class can be given where "Type[VoiceComponent]" is expected [misc]
+ tanjun/clients.py:767: error: Only concrete class can be given where "Type[VoiceComponent]" is expected [type-abstract]
- tanjun/clients.py:2247: error: Only concrete class can be given where "Type[SingleStoreCache[OwnUser]]" is expected [misc]
+ tanjun/clients.py:2247: error: Only concrete class can be given where "Type[SingleStoreCache[OwnUser]]" is expected [type-abstract]
- tanjun/clients.py:2296: error: Only concrete class can be given where "Type[SingleStoreCache[Application]]" is expected [misc]
+ tanjun/clients.py:2296: error: Only concrete class can be given where "Type[SingleStoreCache[Application]]" is expected [type-abstract]
prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/packaging/base.py:61: error: Only concrete class can be given where "Type[PackageManifest]" is expected [misc]
+ src/prefect/packaging/base.py:61: error: Only concrete class can be given where "Type[PackageManifest]" is expected [type-abstract]
ibis (https://github.com/ibis-project/ibis)
- ibis/expr/types/generic.py:460: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/generic.py:460: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/generic.py:463: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/generic.py:463: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/generic.py:466: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/generic.py:466: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/generic.py:469: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/generic.py:469: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/generic.py:472: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/generic.py:472: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/generic.py:475: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/generic.py:475: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:207: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:207: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:225: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:225: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:243: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:243: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:280: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:280: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:302: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:302: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:324: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:324: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:376: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:376: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:399: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:399: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:422: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:422: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:506: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:506: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:515: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:515: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:524: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:524: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:533: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:533: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/temporal.py:542: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/temporal.py:542: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/strings.py:808: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/strings.py:808: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:212: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:212: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:218: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:218: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:224: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:224: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:230: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:230: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:244: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:244: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:253: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:253: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:262: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:262: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:268: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:268: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:274: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:274: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:280: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:280: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:287: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:287: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:673: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:673: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:681: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:681: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:689: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:689: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:697: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:697: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:705: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:705: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:711: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:711: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/numeric.py:719: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/numeric.py:719: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/logical.py:51: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/logical.py:51: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/logical.py:56: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/logical.py:56: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
- ibis/expr/types/logical.py:61: error: Only concrete class can be given where "Type[Binary]" is expected [misc]
+ ibis/expr/types/logical.py:61: error: Only concrete class can be given where "Type[Binary]" is expected [type-abstract]
|
|
@ilevkivskyi Thanks for the updated error code. It seems not to be available in the 0.982 yet. Will it be added to 0.983? |
|
There will be no 0.983, next release is 0.990, see #13871 (and yes, this will be included) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4717
This will allow people who consider this check too strict to opt-out easily using
--disable-error-code=type-abstract.