Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current isort config doesn't fully work for the pre-commit hook. Whereas in tox isort is called with the global
.
path, pre-commit passes all filenames individually.E.g. running this command will also reformat the
mypy/typeshed
directory:Using
skip_glob
instead ofskip
will resolve the issue.https://pycqa.github.io/isort/docs/configuration/options.html#skip-glob
Followup to #13832 (comment)
/CC: @hauntsaninja