Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isort skip config #13849

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Fix isort skip config #13849

merged 1 commit into from
Oct 9, 2022

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Oct 9, 2022

Our current isort config doesn't fully work for the pre-commit hook. Whereas in tox isort is called with the global . path, pre-commit passes all filenames individually.

E.g. running this command will also reformat the mypy/typeshed directory:

pre-commit run isort --all-files

Using skip_glob instead of skip will resolve the issue.
https://pycqa.github.io/isort/docs/configuration/options.html#skip-glob

Followup to #13832 (comment)
/CC: @hauntsaninja

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this! :-)

@hauntsaninja hauntsaninja merged commit edf83f3 into python:master Oct 9, 2022
@cdce8p cdce8p deleted the isort-config branch October 9, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants