Always mention explicit export when relevant #13925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to python#13917 and python#13908. This handles situations involving per-module re-exports correctly / is consistent with the error you'd get with attribute access.
sobolevn
approved these changes
Oct 19, 2022
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: streamlit (https://github.com/streamlit/streamlit)
- lib/tests/streamlit/config_option_test.py:20:1: error: Module "streamlit.config_option" does not explicitly export attribute "DeprecationError"; implicit reexport disabled [attr-defined]
+ lib/tests/streamlit/config_option_test.py:20:1: error: Module "streamlit.config_option" does not explicitly export attribute "DeprecationError" [attr-defined]
- lib/tests/streamlit/web/server/routes_test.py:28:1: error: Module "streamlit.web.server.server" does not explicitly export attribute "HealthHandler"; implicit reexport disabled [attr-defined]
+ lib/tests/streamlit/web/server/routes_test.py:28:1: error: Module "streamlit.web.server.server" does not explicitly export attribute "HealthHandler" [attr-defined]
- lib/tests/streamlit/web/server/routes_test.py:28:1: error: Module "streamlit.web.server.server" does not explicitly export attribute "MessageCacheHandler"; implicit reexport disabled [attr-defined]
+ lib/tests/streamlit/web/server/routes_test.py:28:1: error: Module "streamlit.web.server.server" does not explicitly export attribute "MessageCacheHandler" [attr-defined]
- lib/tests/streamlit/web/server/routes_test.py:28:1: error: Module "streamlit.web.server.server" does not explicitly export attribute "StaticFileHandler"; implicit reexport disabled [attr-defined]
+ lib/tests/streamlit/web/server/routes_test.py:28:1: error: Module "streamlit.web.server.server" does not explicitly export attribute "StaticFileHandler" [attr-defined]
- lib/tests/streamlit/web/server/component_request_handler_test.py:21:1: error: Module "streamlit.web.server" does not explicitly export attribute "ComponentRequestHandler"; implicit reexport disabled [attr-defined]
+ lib/tests/streamlit/web/server/component_request_handler_test.py:21:1: error: Module "streamlit.web.server" does not explicitly export attribute "ComponentRequestHandler" [attr-defined]
- lib/tests/streamlit/web/server/browser_websocket_handler_test.py:25:1: error: Module "streamlit.web.server.server" does not explicitly export attribute "BrowserWebSocketHandler"; implicit reexport disabled [attr-defined]
+ lib/tests/streamlit/web/server/browser_websocket_handler_test.py:25:1: error: Module "streamlit.web.server.server" does not explicitly export attribute "BrowserWebSocketHandler" [attr-defined]
- lib/tests/streamlit/runtime/caching/common_cache_test.py:24:1: error: Module "streamlit.runtime.caching" does not explicitly export attribute "MEMO_CALL_STACK"; implicit reexport disabled [attr-defined]
+ lib/tests/streamlit/runtime/caching/common_cache_test.py:24:1: error: Module "streamlit.runtime.caching" does not explicitly export attribute "MEMO_CALL_STACK" [attr-defined]
- lib/tests/streamlit/runtime/caching/common_cache_test.py:24:1: error: Module "streamlit.runtime.caching" does not explicitly export attribute "SINGLETON_CALL_STACK"; implicit reexport disabled [attr-defined]
+ lib/tests/streamlit/runtime/caching/common_cache_test.py:24:1: error: Module "streamlit.runtime.caching" does not explicitly export attribute "SINGLETON_CALL_STACK" [attr-defined]
werkzeug (https://github.com/pallets/werkzeug)
- tests/test_debug.py:8: error: Module "werkzeug.debug" does not explicitly export attribute "DebugTraceback"; implicit reexport disabled [attr-defined]
+ tests/test_debug.py:8: error: Module "werkzeug.debug" does not explicitly export attribute "DebugTraceback" [attr-defined]
parso (https://github.com/davidhalter/parso)
- parso/python/tree.py:49: error: Module "collections" has no attribute "Mapping" [attr-defined]
+ parso/python/tree.py:49: error: Module "collections" does not explicitly export attribute "Mapping" [attr-defined]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13917 and #13908. This handles situations involving per-module re-exports correctly / is consistent with the error you'd get with attribute access.