Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add warning about stubtest code execution #13927

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Conversation

sobolevn
Copy link
Member

Some of my students asked about this. I think it is better to have this information in the docs: it is important.

Comment on lines 46 to 47
stubtest attempts to import specified python modules.
It will execute all module level code. Please, keep this in mind.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stubtest attempts to import specified python modules.
It will execute all module level code. Please, keep this in mind.
stubtest attempts to import specified Python modules.
It will execute all module level code.

"keep this in mind" doesn't really add anything

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hauntsaninja hauntsaninja merged commit ace0f32 into master Oct 20, 2022
@hauntsaninja hauntsaninja deleted the sobolevn-patch-3 branch October 20, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants